Prevent unhandled promises in createAsyncThunk #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 087b606 https://deploy-preview-570--redux-starter-kit-docs.netlify.app |
phryneas
reviewed
May 20, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 087b606:
|
msutkowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There is currently not a good way to test that
unhandledRejectionerrors happen or not. This PR introduces a method that will 'crash' the test runner if you happen to forget to resolve a promise.Things tried before going to the 'crash the test runner' route:
process.on('unhandledRejection', {})to use a callback function, and check that it is fired.getLog().After some research, it seems that jest doesn't handle process.on in the test file itself, which is why it's moved into the config. See: jestjs/jest#5620